[clang] 1072b94 - Revert "[clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (#69078)"

[Martin Storsjö via cfe-commits]

Author: Martin Storsjö
Date: 2023-10-18T15:42:18+03:00
New Revision: 1072b94ed8e5a051100557185cb384364850635a

URL: https://github.com/llvm/llvm-project/commit/1072b94ed8e5a051100557185cb384364850635a
DIFF: https://github.com/llvm/llvm-project/commit/1072b94ed8e5a051100557185cb384364850635a.diff

LOG: Revert "[clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (#69078)"

This reverts commit b4b35a5d2b4ee26bf79b8a92715dd200f3f9cc49.

That commit broke builds with -DBUILD_SHARED_LIBS=ON. The reason
is that clang::driver::toolchains::Generic_GCC::GCCVersion::Parse
isn't visible outside of the shared library, because
the Generic_GCC class is marked with LLVM_LIBRARY_VISIBILITY.

Added: 
    

Modified: 
    clang/unittests/Driver/CMakeLists.txt

Removed: 
    clang/unittests/Driver/GCCVersionTest.cpp


################################################################################
diff  --git a/clang/unittests/Driver/CMakeLists.txt b/clang/unittests/Driver/CMakeLists.txt
index 752037f78fb147d..e37c158d7137a88 100644
--- a/clang/unittests/Driver/CMakeLists.txt
+++ b/clang/unittests/Driver/CMakeLists.txt
@@ -9,7 +9,6 @@ set(LLVM_LINK_COMPONENTS
 add_clang_unittest(ClangDriverTests
   DistroTest.cpp
   DXCModeTest.cpp
-  GCCVersionTest.cpp
   ToolChainTest.cpp
   ModuleCacheTest.cpp
   MultilibBuilderTest.cpp

diff  --git a/clang/unittests/Driver/GCCVersionTest.cpp b/clang/unittests/Driver/GCCVersionTest.cpp
deleted file mode 100644
index 9ae335bca77dc12..000000000000000
--- a/clang/unittests/Driver/GCCVersionTest.cpp
+++ /dev/null
@@ -1,52 +0,0 @@
-//===- unittests/Driver/GCCVersionTest.cpp --- GCCVersion parser tests ----===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-//
-// Unit tests for Generic_GCC::GCCVersion
-//
-//===----------------------------------------------------------------------===//
-
-#include "../../lib/Driver/ToolChains/Gnu.h"
-#include "gtest/gtest.h"
-
-using namespace clang;
-using namespace clang::driver;
-
-namespace {
-
-struct VersionParseTest {
-  std::string Text;
-
-  int Major, Minor, Patch;
-  std::string MajorStr, MinorStr, PatchSuffix;
-};
-
-const VersionParseTest TestCases[] = {
-    {"5", 5, -1, -1, "5", "", ""},
-    {"4.4", 4, 4, -1, "4", "4", ""},
-    {"4.4-patched", 4, 4, -1, "4", "4", "-patched"},
-    {"4.4.0", 4, 4, 0, "4", "4", ""},
-    {"4.4.x", 4, 4, -1, "4", "4", ""},
-    {"4.4.2-rc4", 4, 4, 2, "4", "4", "-rc4"},
-    {"4.4.x-patched", 4, 4, -1, "4", "4", ""},
-    {"not-a-version", -1, -1, -1, "", "", ""},
-};
-
-TEST(GCCVersionTest, Parse) {
-  for (const auto &TC : TestCases) {
-    auto V = toolchains::Generic_GCC::GCCVersion::Parse(TC.Text);
-    EXPECT_EQ(V.Text, TC.Text);
-    EXPECT_EQ(V.Major, TC.Major);
-    EXPECT_EQ(V.Minor, TC.Minor);
-    EXPECT_EQ(V.Patch, TC.Patch);
-    EXPECT_EQ(V.MajorStr, TC.MajorStr);
-    EXPECT_EQ(V.MinorStr, TC.MinorStr);
-    EXPECT_EQ(V.PatchSuffix, TC.PatchSuffix);
-  }
-}
-
-} // end anonymous namespace