[PATCH] D155850: [HIP][Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

Alex Voicu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 17 07:04:40 PDT 2023


AlexVlx added a comment.

In D155850#4654146 <https://reviews.llvm.org/D155850#4654146>, @hnrklssn wrote:

> `clang/test/CodeGenHipStdPar/unannotated-functions-get-emitted.cpp` is failing: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/38041/testReport/junit/Clang/CodeGenHipStdPar/unannotated_functions_get_emitted_cpp/
>
>   project/clang/test/CodeGenHipStdPar/unannotated-functions-get-emitted.cpp:15:22: error: NO-HIPSTDPAR-DEV: expected string not found in input
>   // NO-HIPSTDPAR-DEV: define {{.*}} void @bar({{.*}})
>                        ^
>   <stdin>:1:1: note: scanning from here
>   ; ModuleID = '/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/clang/test/CodeGenHipStdPar/unannotated-functions-get-emitted.cpp'
>   ^
>   <stdin>:7:1: note: possible intended match here
>   define void @bar(ptr noundef %a, float noundef %b) #0 {
>   ^
>
> It looks like it may be due to the matcher having whitespace on both sides of `{{.*}}`, while the output only has a single space between `define` and `void`, but I'm not too well versed in FileCheck edge cases to know for sure.

Thank you for the ping... this is pretty confusing since it's not tripping any of the buildbots, or flaring locally, let me look into it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155850/new/

https://reviews.llvm.org/D155850



More information about the cfe-commits mailing list