[clang] b7de1d0 - [Clang][NFC] Use correct tool name for NVIDIA's 'nvlink'

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 16 13:42:45 PDT 2023


Author: Joseph Huber
Date: 2023-10-16T15:41:01-05:00
New Revision: b7de1d07e5298bdd97816043360ea334378f5565

URL: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565
DIFF: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565.diff

LOG: [Clang][NFC] Use correct tool name for NVIDIA's 'nvlink'

Summary:
This step was incorrectly called 'fatbinary', so if it failed here it
would say 'fatbinary' was the cause of the failure. This is actually
'nvlink' so we should adjust this.

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/Cuda.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/Cuda.h b/clang/lib/Driver/ToolChains/Cuda.h
index 39df6e06fb26dea..f7c0c7ea1c98c8d 100644
--- a/clang/lib/Driver/ToolChains/Cuda.h
+++ b/clang/lib/Driver/ToolChains/Cuda.h
@@ -110,7 +110,7 @@ class LLVM_LIBRARY_VISIBILITY FatBinary : public Tool {
 // Runs nvlink, which links GPU object files ("cubin" files) into a single file.
 class LLVM_LIBRARY_VISIBILITY Linker : public Tool {
 public:
-  Linker(const ToolChain &TC) : Tool("NVPTX::Linker", "fatbinary", TC) {}
+  Linker(const ToolChain &TC) : Tool("NVPTX::Linker", "nvlink", TC) {}
 
   bool hasIntegratedCPP() const override { return false; }
 


        


More information about the cfe-commits mailing list