[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

[Caroline via Phabricator via cfe-commits]

CarolineConcatto added inline comments.
Herald added a subscriber: wangpc.


================
Comment at: clang/include/clang/Basic/arm_sve.td:2123
+
+def SVPSEL_COUNT_ALIAS_B : SInst<"svpsel_lane_c8",  "}}Pmi", "Pc", MergeNone, "", [], [ImmCheck<3, ImmCheck0_15>]>;
+def SVPSEL_COUNT_ALIAS_H : SInst<"svpsel_lane_c16", "}}Pmi", "Ps", MergeNone, "", [], [ImmCheck<3, ImmCheck0_7>]>;
----------------
hassnaa-arm wrote:
> In the section of prototype modifiers: "}}Pmi"
> According to the used modifiers, I see that they refer to 4 parameters, while in the testing file I see the function takes 3 parameters only.
> Isn't that 'i' modifier extra ?
> The same case for all the builtins.
> Am I correct ?
It looks we have a change in the way we use slice. Now the base and offset are only 1 parameter.
So this prototype has changed.
I will update this patch
See https://github.com/ARM-software/acle/pull/217/files


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151197/new/

https://reviews.llvm.org/D151197