[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

[via cfe-commits]

Da-Viper wrote:

Ok, I do have a few questions.

1. Currently this check does not match typedefs in functions regardless of
extern c.should this be the case.

2. where do I find the release notes.

On Sun, 15 Oct 2023, 13:36 Piotr Zegar, ***@***.***> wrote:

> I got mixed feelings about this. Simply we can use 'using' within extern
> "C", there is nothing wrong with this. using/typedef doesn't haven linkage,
> that just type alias. And extern "C" does not impact it. In oryginal issue
> I think someone mistook extern "C" into something where only "C" code
> should be put, and that's not true. All what extern "C" does it's using C
> style symbol mangling for functions inside.
>
> The only reason to not use 'using' in extern 'C' would be just
> readability, to avoid some confusion.
> As for this change, release notes & doc is needed.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/69102#issuecomment-1763376279>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AN2DXISRXSJCEEZ7OEU2DTLX7PKDTAVCNFSM6AAAAAA6A5MI3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGM3TMMRXHE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/69102