[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 11:22:47 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff dd0f642e6ec5049ccabe3f462cc427ffe213829b 71f1352bf00d6a9eefa3f199859d47d093f272f8 -- clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h clang/lib/Basic/Targets/X86.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/builtin-cpu-supports.c clang/test/Sema/builtin-cpu-supports.c llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp llvm/lib/Target/PowerPC/PPCInstrInfo.cpp llvm/lib/Target/PowerPC/PPCTargetMachine.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 583b2be69..c5920216e 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -16093,8 +16093,7 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned BuiltinID,
 #define PPC_CPU(Name, NumericID) .Case(Name, NumericID)
 #include "llvm/TargetParser/PPCTargetParser.def"
                             .Default(-1U);
-    Value *Op0 =
-        llvm::ConstantInt::get(Int32Ty, PPC_FAWORD_CPUID);
+    Value *Op0 = llvm::ConstantInt::get(Int32Ty, PPC_FAWORD_CPUID);
     llvm::Function *F = CGM.getIntrinsic(Intrinsic::ppc_fixed_addr_ld);
     Value *TheCall = Builder.CreateCall(F, {Op0}, "cpu_is");
     return Builder.CreateICmpEQ(TheCall,
diff --git a/llvm/lib/Target/PowerPC/PPCInstrInfo.cpp b/llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
index 7d4cdd8be..79123cedd 100644
--- a/llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
+++ b/llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
@@ -3139,10 +3139,8 @@ bool PPCInstrInfo::expandPostRAPseudo(MachineInstr &MI) const {
     if ((FAType == PPC_FAWORD_HWCAP && Subtarget.isLittleEndian()) ||
         (FAType == PPC_FAWORD_HWCAP2 && !Subtarget.isLittleEndian()))
       Offset = Subtarget.isPPC64() ? -0x7064 : -0x703C;
-    else if ((FAType == PPC_FAWORD_HWCAP2 &&
-              Subtarget.isLittleEndian()) ||
-             (FAType == PPC_FAWORD_HWCAP &&
-              !Subtarget.isLittleEndian()))
+    else if ((FAType == PPC_FAWORD_HWCAP2 && Subtarget.isLittleEndian()) ||
+             (FAType == PPC_FAWORD_HWCAP && !Subtarget.isLittleEndian()))
       Offset = Subtarget.isPPC64() ? -0x7068 : -0x7040;
     else if (FAType == PPC_FAWORD_CPUID)
       Offset = Subtarget.isPPC64() ? -0x705C : -0x7034;

``````````

</details>


https://github.com/llvm/llvm-project/pull/68919


More information about the cfe-commits mailing list