[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 05:29:55 PDT 2023


================
@@ -420,20 +444,35 @@ bool ARM::appendArchExtFeatures(StringRef CPU, ARM::ArchKind AK,
     CPU = "generic";
 
   if (ArchExt == "fp" || ArchExt == "fp.dp") {
+    const ARM::FPUKind DefaultFPU = getDefaultFPU(CPU, AK);
     ARM::FPUKind FPUKind;
     if (ArchExt == "fp.dp") {
+      const bool IsDP = ArgFPUKind != ARM::FK_INVALID &&
+                        ArgFPUKind != ARM::FK_NONE &&
+                        isDoublePrecision(getFPURestriction(ArgFPUKind));
----------------
john-brawn-arm wrote:

This function is called in order to set ArgFPUKind, so checking it here (and below) looks strange. I would expect it to always be FK_INVALID, is there any situation in which it's not?

https://github.com/llvm/llvm-project/pull/67412


More information about the cfe-commits mailing list