[PATCH] D156784: [AArch64][PAC] Declare FPAC subtarget feature

Anatoly Trosinenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 11 05:39:37 PDT 2023


atrosinenko added a comment.

As discussed in D156716 <https://reviews.llvm.org/D156716>, it is not clear if I have to add FeatureFPAC to every relevant CPU. Maybe it is worth conservatively assuming that this feature should only be enabled manually by the user as a precaution against "I have CPU core X but it is not listed, so let's use cpu=Y because X supports all the instructions supported by Y //(but not FEAT_FPAC)//" - that would not cause any obvious run-time crashes under normal operation, but would make the code less secure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156784/new/

https://reviews.llvm.org/D156784



More information about the cfe-commits mailing list