[PATCH] D140925: [CMake] Use Clang to infer the target triple

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 10 17:04:05 PDT 2023


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: runtimes/CMakeLists.txt:167
 
+if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
+  set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple)
----------------
Is there any reason why you're carving out Apple here? Is it because `-print-target-triple` doesn't work properly on that platform (I think this rings a bell).

Anyway, this is non-blocking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140925/new/

https://reviews.llvm.org/D140925



More information about the cfe-commits mailing list