[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

Alexei Starovoitov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 10 11:55:51 PDT 2023


ast added inline comments.


================
Comment at: clang/lib/CodeGen/CGExpr.cpp:3791
+  if (hasBPFPreserveStaticOffset(Base))
+    addr = wrapWithBPFPreserveStaticOffset(CGF, addr);
+
----------------
If I'm reading this correctly wrapping with preserve_static_offset doesn't prevent further preserver_access_index wrapping which is a wasted effort for pai at the end ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133361/new/

https://reviews.llvm.org/D133361



More information about the cfe-commits mailing list