[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

Fei Peng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 9 14:04:48 PDT 2023


fiigii added a comment.

> The reverse transform is only done if A + B simplifies.

Looks like`simplifyAddInst` may give add expressions, so I guess this patch may make IC run into infinite loops.

Additionally, this change could make longer GEP chains that could hurt other optimizations by exceeding AA or value-tracking thresholds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155688/new/

https://reviews.llvm.org/D155688



More information about the cfe-commits mailing list