[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

For assembly, I'm not really comfortable with the fix you're proposing; it relies on the order in which functions are defined in assembly.  I think LLVM usually ends up emitting module-level inline assembly before generated code, but it seems fragile to depend on that ordering.  And the way the check is written doesn't account for other differences in the way we normally generate code for declarations vs. definitions, which I'm afraid might make the linker unhappy.

How important is that particular pattern?  I think most patterns involving assembly should be covered by some combination of naked functions, and functions defined in separate assembly files, both of which avoid weird questions about what the compiler should do when assembly tries to define a function symbol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157547/new/

https://reviews.llvm.org/D157547