ChuanqiXu9 wrote: @sam-mccall thanks for your high qualified comments! I think I've addressed most of them. I am not so familiar with the Github review system. Tell me if you're more happy with other practices. https://github.com/llvm/llvm-project/pull/66462