[clang] [RISCV][LLD] Add RISCV zcmt optimise in linker relaxation (PR #68551)

Jessica Clarke via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 8 21:41:46 PDT 2023


jrtc27 wrote:

> > > This patch is moved from https://reviews.llvm.org/D134600
> > 
> > 
> > Why? That loses all the context in the Phabricator review. Keep the review there.
> 
> yes, I will keep it there.
> 
> But the [Phabricator shutdown timeline](https://discourse.llvm.org/t/update-on-github-pull-requests/71540) said that
> 
> > Phabricator becomes read-only after October 1
> 
> So I thought it may means we can't add comments or update it? That's why I moved it from Phabricator.
> 
> If you mean we still can review&update it at Phabricator, I will close this pr. )

Scroll down the thread and you will find https://discourse.llvm.org/t/update-on-github-pull-requests/71540/124. There's consensus that Phabricator will remain usable for existing revisions for a while longer for this specific kind of situation, and that migrating revisions off of it loses valuable context and should be avoided.

https://github.com/llvm/llvm-project/pull/68551


More information about the cfe-commits mailing list