[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

[Aaron Puchert via cfe-commits]

Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/67095/clang at github.com>


https://github.com/aaronpuchert commented:

> This was much easier than expected actually.

Making it a `DeclOrType` attribute is indeed a nice idea, this would allow existing attributes to stay where they are. Is it still inheritable, i.e. does it also apply to later redeclarations?

Of course I'm also wondering why we don't have to change anything in the analysis, aren't we currently only looking at declaration attributes, and wouldn't consider attributes on the type? Or is there some mechanism that gives us the combined set of declaration and type attributes?

> I'm starting a new review here instead of continuing the one in Phab since this is a completely different attempt. I hope that's ok.

Yeah, since it's a completely different approach than https://reviews.llvm.org/D152246 we're not really losing any history.

https://github.com/llvm/llvm-project/pull/67095