[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

Valentin Churavy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 7 16:04:00 PDT 2023


vchuravy added a subscriber: loladiro.
vchuravy added a comment.

In D137149#4653308 <https://reviews.llvm.org/D137149#4653308>, @aeubanks wrote:

> we don't currently support reusing a pipeline so I'm surprised that you're able to share/reuse pipelines without running into any issues

In addition to @pchintalapudi's comment. Reuse of pipelines is something that we (JuliaLang) had come to expect from old PM. This is why opt had a `-run-twice` option to help flush
out bugs that arose out of the idea that passes would only be used once. @loladiro might remember those discussions.

So when we ported Julia to NewPM I didn't think twice and @pchintalapudi implemented our NewPM usage such that only the AnalysisManager
would be created fresh.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137149/new/

https://reviews.llvm.org/D137149



More information about the cfe-commits mailing list