[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

Sat Oct 7 08:44:10 PDT 2023

cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.

@aaron.ballman Given the recent discussion we had on both github (https://github.com/llvm/llvm-project/pull/66203) and privately, I'm going to accept that.
We only create ConstantExpr for ICE and immediate invocations, so it would have a much less limited and impact that first envisioned (we should fix that, cf https://github.com/llvm/llvm-project/issues/61425), and so we don't have good benchmarks were this patch makes things better,
but it also doesn't make things worse and in helps in limited cases.

We should probably investigate as a follow up whether we should use `ConstantExpr` in more places

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155548/new/

https://reviews.llvm.org/D155548