[clang] [Fuchsia] Change driver build to default to off (PR #68341)

Alex Brachet via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 5 11:32:54 PDT 2023


https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/68341

We use this cache file for local builds too where the driver build is not a sensible default because it makes incremental links take too long. Instead lets change this option to be opt in.

>From f8464ee99b3b2b36754cb3c46e4419daf9482232 Mon Sep 17 00:00:00 2001
From: Alex Brachet <abrachet at google.com>
Date: Thu, 5 Oct 2023 14:27:59 -0400
Subject: [PATCH] [Fuchsia] Change driver build to default to off

We use this cache file for local builds too where the driver build
is not a sensible default because it makes incremental links take
too long. Instead lets change this option to be opt in.
---
 clang/cmake/caches/Fuchsia-stage2.cmake | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.cmake
index 0dcc35ee1495f55..cca53be3dc45e33 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -29,11 +29,7 @@ set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "")
 set(LLDB_ENABLE_CURSES OFF CACHE BOOL "")
 set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "")
 
-if(WIN32)
-  set(FUCHSIA_DISABLE_DRIVER_BUILD ON)
-endif()
-
-if (NOT FUCHSIA_DISABLE_DRIVER_BUILD)
+if (FUCHSIA_ENABLE_DRIVER_BUILD)
   set(LLVM_TOOL_LLVM_DRIVER_BUILD ON CACHE BOOL "")
   set(LLVM_DRIVER_TARGET llvm-driver)
 endif()



More information about the cfe-commits mailing list