[PATCH] D157331: [clang] Implement C23 <stdckdint.h>

Jessica Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 5 11:21:34 PDT 2023


jrtc27 added inline comments.


================
Comment at: clang/test/C/C2x/n2683_2.c:14
+// CHECK:    store i64 %2, ptr %[[RES64]], align 8
+// CHECK:    %frombool = zext i1 %1 to i8
+// CHECK:    store i8 %frombool, ptr %[[FLAG_ADD:.*]], align 1
----------------
You missed this one. But please just use the script, it makes everyone's lives easier, both in the present (no need to worry that you've forgotten anything) and in the future (should Clang's code generation change it's much easier to rerun the script rather than hand-edit every test; which also includes downstreams that alter behaviour, which I am very familiar with thanks to my day job).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157331/new/

https://reviews.llvm.org/D157331



More information about the cfe-commits mailing list