[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 5 05:53:22 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 5099dc341f7fa9baec160c2991072eb445469d46 0be9c9fc769eb580a602ce075d8904d683c3596b -- clang/lib/CodeGen/Targets/AMDGPU.cpp clang/test/OpenMP/target_visibility.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CodeGen/Targets/AMDGPU.cpp b/clang/lib/CodeGen/Targets/AMDGPU.cpp
index def8bf45af76..4fb0aa352931 100644
--- a/clang/lib/CodeGen/Targets/AMDGPU.cpp
+++ b/clang/lib/CodeGen/Targets/AMDGPU.cpp
@@ -309,8 +309,8 @@ static bool requiresAMDGPUProtectedVisibility(const Decl *D,
     return false;
 
   if (auto *Attr = D->getAttr<OMPDeclareTargetDeclAttr>())
-    return isa<VarDecl>(D) && OMPDeclareTargetDeclAttr::DT_NoHost !=
-      Attr->getDevType();
+    return isa<VarDecl>(D) &&
+           OMPDeclareTargetDeclAttr::DT_NoHost != Attr->getDevType();
 
   return D->hasAttr<OpenCLKernelAttr>() ||
          (isa<FunctionDecl>(D) && D->hasAttr<CUDAGlobalAttr>()) ||

``````````

</details>


https://github.com/llvm/llvm-project/pull/68264


More information about the cfe-commits mailing list