[clang] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 4 07:20:44 PDT 2023


================
@@ -53,6 +55,16 @@ static Value truncToI32(ConversionPatternRewriter &rewriter, Location loc,
   return rewriter.create<LLVM::TruncOp>(loc, rewriter.getI32Type(), value);
 }
 
+/// Returns warp-size as a value.
+static Value getWarpSizeValue(ImplicitLocOpBuilder &b) {
----------------
qcolombet wrote:

Second thing, the implementation of the singleton is going to break whenever we run the code on more than one function, since the builder will change and we'll still return the value of the very first one. (Which at this point could have been destroyed, reassigned, etc.)

Long story short, drop the singleton construct :).

https://github.com/llvm/llvm-project/pull/65441


More information about the cfe-commits mailing list