[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

Rajkumar Ananthu via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 4 06:09:59 PDT 2023


================
@@ -4628,6 +4628,12 @@ ASTFileSignature ASTWriter::WriteAST(Sema &SemaRef, StringRef OutputFile,
   WritingAST = true;
 
   ASTHasCompilerErrors = hasErrors;
+  bool trueHasErrors = SemaRef.PP.getDiagnostics().hasUncompilableErrorOccurred();
----------------
rajkumarananthu wrote:

Yeah @AaronBallman, that does sound better, I will remove the argument and update the pull request. Thanks for the review.

https://github.com/llvm/llvm-project/pull/68127


More information about the cfe-commits mailing list