[clang] [clang-repl] Disable InterpreterExceptionTest on RISC-V (PR #68216)

Alex Bradbury via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 4 05:54:56 PDT 2023


https://github.com/asb created https://github.com/llvm/llvm-project/pull/68216

This test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. #66067 is proposed to address this.

Skip the test until the issue is resolved. It seems that D159167 enabled this test for more than just ppc64. As the test always failed, it just wasn't run until now, I think skipping is the correct interim approach (as is already done for Arm, Darwin, and others).

>From 6436cffbe1d4767155724b1c28acd8b47bb6be88 Mon Sep 17 00:00:00 2001
From: Alex Bradbury <asb at igalia.com>
Date: Wed, 4 Oct 2023 13:51:20 +0100
Subject: [PATCH] [clang-repl] Disable InterpreterExceptionTest on RISC-V

This test fails as .eh_frame handling is not yet implemented for RISC-V
in JITLink. #66067 is proposed to address this.

Skip the test until the issue is resolved. It seems that D159167
enabled this test for more than just ppc64.
---
 .../Interpreter/ExceptionTests/InterpreterExceptionTest.cpp  | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
index 2f1c4efb381f00b..7b47d93446192ba 100644
--- a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
+++ b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
@@ -122,6 +122,11 @@ extern "C" int throw_exception() {
                               Triple.getArch() == llvm::Triple::aarch64_32))
     GTEST_SKIP();
 
+  // FIXME: RISC-V fails as .eh_frame handling is not yet implemented in
+  // JITLink for RISC-V. See PR #66067.
+  if (Triple.isRISCV())
+    GTEST_SKIP();
+
   llvm::cantFail(Interp->ParseAndExecute(ExceptionCode));
   testing::internal::CaptureStdout();
   auto ThrowException =



More information about the cfe-commits mailing list