[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 3 09:38:46 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 0701ee69f7ac82b49a9709e610227ebf387f1d30 b76f4d351b3e55e2095e3be088a50fdb76d6b7f9 -- clang/lib/Serialization/ASTWriter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp
index 35f37de9b185..0d75dbbbad8f 100644
--- a/clang/lib/Serialization/ASTWriter.cpp
+++ b/clang/lib/Serialization/ASTWriter.cpp
@@ -4628,11 +4628,12 @@ ASTFileSignature ASTWriter::WriteAST(Sema &SemaRef, StringRef OutputFile,
   WritingAST = true;
 
   ASTHasCompilerErrors = hasErrors;
-  bool trueHasErrors = SemaRef.PP.getDiagnostics().hasUncompilableErrorOccurred();
+  bool trueHasErrors =
+      SemaRef.PP.getDiagnostics().hasUncompilableErrorOccurred();
   assert(ASTHasCompilerErrors == trueHasErrors);
   if (trueHasErrors != ASTHasCompilerErrors) {
-      // forcing the compiler errors flag to be set correctly
-      ASTHasCompilerErrors = trueHasErrors;
+    // forcing the compiler errors flag to be set correctly
+    ASTHasCompilerErrors = trueHasErrors;
   }
 
   // Emit the file header.

``````````

</details>


https://github.com/llvm/llvm-project/pull/68127


More information about the cfe-commits mailing list