[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

Tue Oct 3 08:45:46 PDT 2023

yaxunl added a comment.

In D155775#4652686 <https://reviews.llvm.org/D155775#4652686>, @AlexVlx wrote:

> In D155775#4652683 <https://reviews.llvm.org/D155775#4652683>, @thakis wrote:
>
>> This seems to break tests on Mac and windows, see eg http://45.33.8.238/macm1/70415/step_7.txt
>>
>> Please take a look and revert for now if it takes a while to fix.
>
> Whoops, thank you for flagging this, my bad. At the moment (and for the foreseeable future) this is Linux only, so I think I'd rather XFAIL it on non Linux targets, if that's OK.

LGTM

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155775/new/

https://reviews.llvm.org/D155775