[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

Daniel Paoliello via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 16:47:10 PDT 2023


dpaoliello added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:248-257
+  // The first 4 FP/Vector arguments are passed in XMM registers.
+  CCIfType<[f16],
+           CCAssignToRegWithShadow<[H0, H1, H2, H3],
+                                   [X0, X1, X2, X2]>>,
+  CCIfType<[f32],
+           CCAssignToRegWithShadow<[S0, S1, S2, S3],
+                                   [X0, X1, X2, X2]>>,
----------------
These seem wrong, shouldn't the shadows be `[X0, X1, X2, X3]` (instead of `X2` twice)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157547/new/

https://reviews.llvm.org/D157547



More information about the cfe-commits mailing list