[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

Jakub Kuderski via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 08:07:56 PDT 2023


================
@@ -103,6 +103,14 @@ template <typename T, size_t PageSize = 1024 / sizeof(T)> class PagedVector {
   /// Return the size of the vector.
   [[nodiscard]] size_t size() const { return Size; }
 
+  /// @return true in case the element at index @a Index belongs to a page which
+  /// was already materialised.
----------------
kuhar wrote:

nit: This uses a different style than all the other function documentation in this file. For consistency, shouldn't this be something like:
```suggestion
  /// Return true if the element at `Index` belongs to a page which was already
  /// materialized, i.e., had at least one element accessed.
```

https://github.com/llvm/llvm-project/pull/67960


More information about the cfe-commits mailing list