[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D133361#4652102 <https://reviews.llvm.org/D133361#4652102>, @eddyz87 wrote:

> Rebase, changes as requested by @aaron.ballman and @erichkeane.
>
> Hi @aaron.ballman, @erichkeane,
>
> Thank you for taking a look.
> I beleive this commit covers all feedback except "clang version"
> metadata comment by @erichkeane, I added inline reply there.
>
>> This will also need reviewers for the LLVM changes -- any ideas on
>> who usually reviews BPF-related changes in LLVM?
>
> I'll communicate with @ast and @yonghong-song.

I don't see the comment response you had to me.



================
Comment at: clang/lib/CodeGen/CGExpr.cpp:3700
+    return false;
+  if (auto *BaseDecl = E->getType()->getPointeeType()->getAsRecordDecl())
+    return hasBPFPreserveStaticOffset(BaseDecl);
----------------
getPointeeType can also return nullptr, so unless you have a test elsewhere to ensure it isn't, you likely have to do a little more work here (and if so, I'd need an assert).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133361/new/

https://reviews.llvm.org/D133361