[clang] Introduce paged vector (PR #66430)

via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 05:13:57 PDT 2023


mikaelholmen wrote:

Hi @vgvassilev !
Compiling this with gcc we see lots of warnings like
`
../include/llvm/ADT/PagedVector.h:213:59: warning: friend declaration 'bool llvm::operator==(const llvm::PagedVector<T, PageSize>::MaterializedIterator&, const llvm::PagedVector<T, PageSize>::MaterializedIterator&)' declares a non-template function [-Wnon-template-friend]
  213 |                            MaterializedIterator const &RHS);
      |                                                           ^
../include/llvm/ADT/PagedVector.h:213:59: note: (if this is not what you intended, make sure the function template has already been declared and add <> after the function name here) 
../include/llvm/ADT/PagedVector.h:215:59: warning: friend declaration 'bool llvm::operator!=(const llvm::PagedVector<T, PageSize>::MaterializedIterator&, const llvm::PagedVector<T, PageSize>::MaterializedIterator&)' declares a non-template function [-Wnon-template-friend]
  215 |                            MaterializedIterator const &RHS);
      |                                            
`
Anything that could/should be fixed even if clang seems to not bother?

https://github.com/llvm/llvm-project/pull/66430


More information about the cfe-commits mailing list