[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 03:39:35 PDT 2023


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:6230
     BindKind = BC->getBindKind();
+
   // First check CancelRegion which is then used in checkNestingOfRegions.
----------------
Remove this new line


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:6245-6248
+  UseClausesWithoutBind = mapLoopConstruct(
+      ClausesWithoutBind, Clauses, BindKind, Kind, PrevMappedDirective,
+      StartLoc, EndLoc, DirName, CancelRegion);
 
----------------
Can we do this before checks in lines 6232-6235 so we can avoid double call of checkNestingOfRegions for bind?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158266/new/

https://reviews.llvm.org/D158266



More information about the cfe-commits mailing list