[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

[Nouman Amir via Phabricator via cfe-commits]

NoumanAmir657 added a comment.

In D158540#4652051 <https://reviews.llvm.org/D158540#4652051>, @aaron.ballman wrote:

> In D158540#4651859 <https://reviews.llvm.org/D158540#4651859>, @NoumanAmir657 wrote:
>
>> @aaron.Ballman 
>> Do I need to make changes other than this? The virtual base diagnostic doesn't have a test case in files that would generate it. Should I add the above example as the test case?
>
> You'll need to add a test case to demonstrate the changes, and the example you had above would work well for the tests. You should also add a release note to `clang/docs/ReleaseNotes.rst` so users know about the improvement. But I think that should basically be all that's left to do here.

Added tests and the release note.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158540/new/

https://reviews.llvm.org/D158540