[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

[Fangrui Song via Phabricator via cfe-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:68
+  // "Terminal Service Aware" flag is not needed for UEFI applications.
+  CmdArgs.push_back("-tsaware:no");
+
----------------
These options are not tested.


================
Comment at: clang/test/Driver/uefi.c:4
+// RUN:     | FileCheck -check-prefixes=CHECK %s
+// RUN: %clang -### %s --target=x86_64-uefi \
+// RUN:     --sysroot=%S/platform -fuse-ld=lld 2>&1 \
----------------
This RUN line is not needed. If you want to check that x86_64-uefi normalizes to unknown, you can add a unittest instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159541/new/

https://reviews.llvm.org/D159541