[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

Louis Dionne via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 28 08:31:01 PDT 2023


================
@@ -0,0 +1,20 @@
+
+macro(serialize_lit_param param value)
+  string(APPEND SERIALIZED_LIT_PARAMS "config.${param} = ${value}\n")
----------------
ldionne wrote:

This looks reasonable, but could we avoid using the global variable `SERIALIZED_LIT_PARAMS` here? We should thread it through the functions instead, otherwise these functions all "return their result" by modifying the global variable, which is yucky.

https://github.com/llvm/llvm-project/pull/67691


More information about the cfe-commits mailing list