[clang] [clang][dataflow] Show triangle in `<details>` element. (#67431) (PR #67655)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 28 02:37:37 PDT 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-analysis
<details>
<summary>Changes</summary>
Also, change the mouse cursor into a pointer instead of a text cursor.
This makes it more discoverable that the element can be opened and
closed.
---
Full diff: https://github.com/llvm/llvm-project/pull/67655.diff
2 Files Affected:
- (modified) clang/lib/Analysis/FlowSensitive/HTMLLogger.css (+13-2)
- (modified) clang/lib/Analysis/FlowSensitive/HTMLLogger.html (+1-1)
``````````diff
diff --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
index 0ac1902ea4651ec..60c9ee251a425e8 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
@@ -123,10 +123,21 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
-.value summary {
+.value > summary {
background-color: #ace;
display: flex;
- justify-content: space-between;
+ cursor: pointer;
+}
+.value > summary::before {
+ content: '\25ba';
+ margin-right: 0.5em;
+ font-size: 0.9em;
+}
+.value[open] > summary::before {
+ content: '\25bc';
+}
+.value > summary > .location {
+ margin-left: auto;
}
.value .address {
font-size: xx-small;
diff --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.html b/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
index 87695623cb318b2..6d866d57e144866 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
@@ -18,7 +18,7 @@
<template data-if="v.value_id"><span class="address">#{{v.value_id}}</span></template>
</span>
<template data-if="v.location">
- <span>{{v.type}} <span class="address">@{{v.location}}</span></span>
+ <span class="location">{{v.type}} <span class="address">@{{v.location}}</span></span>
</template>
</summary>
<template
``````````
</details>
https://github.com/llvm/llvm-project/pull/67655
More information about the cfe-commits
mailing list