[clang] 3214f7b - Revert "[clang][dataflow] Show triangle in `<details>` element. (#67431)"

Martin Braenne via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 28 02:08:14 PDT 2023


Author: Martin Braenne
Date: 2023-09-28T09:07:20Z
New Revision: 3214f7bf6c6f1218404584b6c36bd3d4033eb22d

URL: https://github.com/llvm/llvm-project/commit/3214f7bf6c6f1218404584b6c36bd3d4033eb22d
DIFF: https://github.com/llvm/llvm-project/commit/3214f7bf6c6f1218404584b6c36bd3d4033eb22d.diff

LOG: Revert "[clang][dataflow] Show triangle in `<details>` element. (#67431)"

This reverts commit fb933fc6d76de854cb9eadf984f8900b9304d347.

The commit broke buildbots due to non-ASCII characters in
HTMLLogger.css.

Added: 
    

Modified: 
    clang/lib/Analysis/FlowSensitive/HTMLLogger.css
    clang/lib/Analysis/FlowSensitive/HTMLLogger.html

Removed: 
    


################################################################################
diff  --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
index 9737d1416f22abe..0ac1902ea4651ec 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
@@ -123,21 +123,10 @@ code.line:has(.bb-select):before {
   font-size: x-small;
   flex-grow: 1;
 }
-.value > summary {
+.value summary {
   background-color: #ace;
   display: flex;
-  cursor: pointer;
-}
-.value > summary::before {
-  content: '►';
-  margin-right: 0.5em;
-  font-size: 0.9em;
-}
-.value[open] > summary::before {
-  content: '▼';
-}
-.value > summary > .location {
-  margin-left: auto;
+  justify-content: space-between;
 }
 .value .address {
   font-size: xx-small;

diff  --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.html b/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
index 6d866d57e144866..87695623cb318b2 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
@@ -18,7 +18,7 @@
         <template data-if="v.value_id"><span class="address">#{{v.value_id}}</span></template>
       </span>
       <template data-if="v.location">
-        <span class="location">{{v.type}} <span class="address">@{{v.location}}</span></span>
+        <span>{{v.type}} <span class="address">@{{v.location}}</span></span>
       </template>
     </summary>
     <template


        


More information about the cfe-commits mailing list