[clang] fb933fc - [clang][dataflow] Show triangle in `<details>` element. (#67431)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 28 01:55:06 PDT 2023
Author: martinboehme
Date: 2023-09-28T10:55:02+02:00
New Revision: fb933fc6d76de854cb9eadf984f8900b9304d347
URL: https://github.com/llvm/llvm-project/commit/fb933fc6d76de854cb9eadf984f8900b9304d347
DIFF: https://github.com/llvm/llvm-project/commit/fb933fc6d76de854cb9eadf984f8900b9304d347.diff
LOG: [clang][dataflow] Show triangle in `<details>` element. (#67431)
Also, change the mouse cursor into a pointer instead of a text cursor.
This makes it more discoverable that the element can be opened and
closed.
Added:
Modified:
clang/lib/Analysis/FlowSensitive/HTMLLogger.css
clang/lib/Analysis/FlowSensitive/HTMLLogger.html
Removed:
################################################################################
diff --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
index 0ac1902ea4651ec..9737d1416f22abe 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
@@ -123,10 +123,21 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
-.value summary {
+.value > summary {
background-color: #ace;
display: flex;
- justify-content: space-between;
+ cursor: pointer;
+}
+.value > summary::before {
+ content: '►';
+ margin-right: 0.5em;
+ font-size: 0.9em;
+}
+.value[open] > summary::before {
+ content: '▼';
+}
+.value > summary > .location {
+ margin-left: auto;
}
.value .address {
font-size: xx-small;
diff --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.html b/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
index 87695623cb318b2..6d866d57e144866 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.html
@@ -18,7 +18,7 @@
<template data-if="v.value_id"><span class="address">#{{v.value_id}}</span></template>
</span>
<template data-if="v.location">
- <span>{{v.type}} <span class="address">@{{v.location}}</span></span>
+ <span class="location">{{v.type}} <span class="address">@{{v.location}}</span></span>
</template>
</summary>
<template
More information about the cfe-commits
mailing list