[clang] 3cbadc5 - [clang][dataflow] Tweak styling of iteration tabs. (#67637)

via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 28 01:34:04 PDT 2023


Author: martinboehme
Date: 2023-09-28T10:34:00+02:00
New Revision: 3cbadc5cdac0bef79c0a640eb015eed93fd6a909

URL: https://github.com/llvm/llvm-project/commit/3cbadc5cdac0bef79c0a640eb015eed93fd6a909
DIFF: https://github.com/llvm/llvm-project/commit/3cbadc5cdac0bef79c0a640eb015eed93fd6a909.diff

LOG: [clang][dataflow] Tweak styling of iteration tabs. (#67637)

- On non-selected tabs, set cursor to 'pointer' to indicate they're
clickable

- Selected tab shares the same background as the contents to emphasize
that it's
associated with that content. (Compare with Google Chrome or VS Code,
which do
  this similarly.)

- Hovered-over tab becomes slightly brighter to indicate that clicking
it will
  make it even brighter (again, Chrome does this in a similar way).

Example:


![image](https://github.com/llvm/llvm-project/assets/29098113/e588068d-edff-49a8-b468-09dbb3255c3e)

(Mouse cursor is over "Iteration 2", but unfortunately I couldn't get
the screenshot to include the cursor.)

Added: 
    

Modified: 
    clang/lib/Analysis/FlowSensitive/HTMLLogger.css

Removed: 
    


################################################################################
diff  --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
index c8212df1f94b81a..0ac1902ea4651ec 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
@@ -64,15 +64,16 @@ section h2 {
   text-align: center;
 }
 #iterations .chooser:not(.iter-select).hover {
-  background-color: #aaa;
+  background-color: #ddd;
 }
 #iterations .iter-select {
   font-weight: bold;
-  background-color: #ccc;
 }
 #iterations .chooser:not(.iter-select) {
   text-decoration: underline;
   color: blue;
+  cursor: pointer;
+  background-color: #ccc;
 }
 
 code.filename {


        


More information about the cfe-commits mailing list