[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

Sam McCall via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 27 02:03:24 PDT 2023


================
@@ -10,6 +10,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "../Basic/Targets/NVPTX.h"
----------------
sam-mccall wrote:

This header is not part of `clangBasic`'s interface, but rather its implementation (`lib/Basic` rather than `include/clang/Basic`).
Sema can't depend on it - if you need to use its APIs from outside clangBasic they should be moved to a public header.

The bazel build shows the problem: https://buildkite.com/llvm-project/upstream-bazel/builds/75928#018ad568-2f7c-4dda-ae90-3b4d787caad7. Breaking bazel is not itself reason to revert, but here it's flagging a real problem that CMake doesn't catch.

I've reverted as 0afbcb20fd908f8bf9073697423da097be7db592 - sorry to do this so abruptly, but I can't fix this myself & such problems block downstream use of LLVM.

https://github.com/llvm/llvm-project/pull/66496


More information about the cfe-commits mailing list