[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 27 00:06:43 PDT 2023


cor3ntin added a comment.

I had a chat with @hubert.reinterpretcast and @tahonermann.
We reached consensus on wanting to make sure the codepoint value is formatted in a future-proof way so that if we ever implement escaping of lone combining codepoint, this case would be handled as well.

To do that, we can:

- * Expose the escaping mechanism) (done by `pushEscapedString` in Diagnostic.cpp) as a new `EscapeStringForDiagnostic` function. Use that to escape the code point (line 16921)

I think that should be the last change we need here. Thanks for being patient with us!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155610/new/

https://reviews.llvm.org/D155610



More information about the cfe-commits mailing list