[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

[Erich Keane via cfe-commits]

erichkeane wrote:

I think we're going to be stuck with 'warning-as-default-error' here, and let compiler-rt and tests/etc opt-out.  I realize that makes the error not as effective, but it is really the one 'good' way for the 'implementation' in this case to handle itself.

https://github.com/llvm/llvm-project/pull/67360