[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

[Aaron Ballman via cfe-commits]

AaronBallman wrote:

I've reverted in 50abfc4298980fc219c7d70ca2567c61e856b614 due to bots going red, I think we may need to make priority-related issues a warning rather than an error.

https://github.com/llvm/llvm-project/pull/67360