[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

[Erich Keane via cfe-commits]

erichkeane wrote:

> runtime, whereas a `consteval` one cannot. WDYT?

This makes sense to me.  Also, see my comment on https://github.com/llvm/llvm-project/pull/67376.  It looks like someone else is messing with this area as well, and are editing things in an incompatible way, so we should make sure that these don't conflict.

https://github.com/llvm/llvm-project/pull/67360