[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 25 16:38:38 PDT 2023


rsmith added a comment.

In D147655#4650666 <https://reviews.llvm.org/D147655#4650666>, @rjmccall wrote:

> Yeah, the more I think about this, the more I think that while (1) Apple should upstream its use of an older default, regardless (2) the existence of any targets at all with an older default means that tests like this always need to be using `-fclang-abi-compat=latest`.

Seems reasonable. I went ahead and made that change in rG940850066290a484144db80f09e6c19709f5fe49 <https://reviews.llvm.org/rG940850066290a484144db80f09e6c19709f5fe49>.

I think we could probably limit this to just the test using `%itanium_abi_triple`, but there's also an affected test specifying `-triple=x86_64-apple-darwin9`, so that might not be enough for your needs. Also, I suppose some vendors might want to carry a patch that changes the default globally rather than on a per-target basis. So I just changed all the tests that touch the new mangling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147655/new/

https://reviews.llvm.org/D147655



More information about the cfe-commits mailing list