[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 25 16:07:40 PDT 2023


================
@@ -5414,6 +5414,8 @@ def note_constraint_normalization_here : Note<
 def note_parameter_mapping_substitution_here : Note<
   "while substituting into concept arguments here; substitution failures not "
   "allowed in concept arguments">;
+def note_building_deduction_guide_here : Note<
+  "while building deduction guide here">;
----------------
zygoloid wrote:

Maybe we could make this a bit more descriptive:
```suggestion
  "while building implicit deduction guide first needed here">;
```
(Can we list the template name in this diagnostic too, "... deduction guide for %0 ..."? Might be nice, but I think it'll be pretty obvious most of the time, so it seems non-essential.)

https://github.com/llvm/llvm-project/pull/67373


More information about the cfe-commits mailing list