[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

Alex Voicu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 25 14:02:16 PDT 2023


AlexVlx added inline comments.


================
Comment at: clang/docs/HIPSupport.rst:266
+
+- ``-hipstdpar`` / ``--hipstdpar`` enables algorithm offload, which depending on
+  phase, has the following effects:
----------------
MaskRay wrote:
> Newer long options that don't use the common prefix like `-f` are preferred to only support `--foo`, not `-foo`.
> Many `--hip*` options don't support `-hip*`. Why add `-hipstdpar`?
Thanks for the review - to answer the question, it was only done for (apparent) symmetry, there's no strong incentive to have the single dash flavour; I will update both this and the driver patch to retain only the double dash flavours.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155769/new/

https://reviews.llvm.org/D155769



More information about the cfe-commits mailing list