[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi @sammccall, your change seems to be causing a test failure on several bots, can you take a look and revert if you need time to investigate?

  ******************** TEST 'Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/8/35' FAILED ********************
  Script(shard):
  --
  GTEST_OUTPUT=json:/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/unittests/Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests-Clang-Unit-1681597-8-35.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=35 GTEST_SHARD_INDEX=8 /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/unittests/Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests
  --
  Script:
  --
  /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/unittests/Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests --gtest_filter=BoolValueDebugStringTest.ComplexBooleanWithSomeNames
  --
  /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/unittests/Analysis/FlowSensitive/DebugSupportTest.cpp:111: Failure
  Value of: Actual
  Expected: is equal to "((Y & V2) | (X | V3))"
    Actual: "((Y & V3) | (X | V2))"
  /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/unittests/Analysis/FlowSensitive/DebugSupportTest.cpp:111
  Value of: Actual
  Expected: is equal to "((Y & V2) | (X | V3))"
    Actual: "((Y & V3) | (X | V2))"
  ********************

Some affected bots:

- https://lab.llvm.org/buildbot/#/builders/139/builds/50255
- https://lab.llvm.org/buildbot/#/builders/216/builds/27735
- https://lab.llvm.org/buildbot/#/builders/247/builds/9334


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153485/new/

https://reviews.llvm.org/D153485