[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

[Richard Smith via cfe-commits]

Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>,
Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>,
Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>,
Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/66514/clang at github.com>


zygoloid wrote:

> One of the remaining tests fails because `PP->getIdentifierInfo()` ends up doing external lookup via `ASTReader`, which ends up emitting a diagnostic itself. Not sure what to do about that atm.

Can we just detect the reentrancy into the highlighting code and skip computing the highlight information entirely in that case, or is the problem more insidious than that? (Is the fact that diagnostic emission triggers lazy identifier deserialization itself a problem?)

https://github.com/llvm/llvm-project/pull/66514