[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

<details>
<summary>Changes</summary>

Just using BLACK makes it invisible in terminals with a dark background.

See this screenshot:

![Screenshot from 2023-09-21 12-03-15](https://github.com/llvm/llvm-project/assets/49720664/245a9c4f-da27-4dbd-a14e-15a01adbc734)

With current clang, the "note:" part of the note is almost invisible, because we select BLACK as its color.

Use CYAN instead, which is also what gcc does.

---
Full diff: https://github.com/llvm/llvm-project/pull/66997.diff


1 Files Affected:

- (modified) clang/lib/Frontend/TextDiagnostic.cpp (+1-1) 


``````````diff
diff --git a/clang/lib/Frontend/TextDiagnostic.cpp b/clang/lib/Frontend/TextDiagnostic.cpp
index eaa6e8d29a1dece..89c7ef505159e13 100644
--- a/clang/lib/Frontend/TextDiagnostic.cpp
+++ b/clang/lib/Frontend/TextDiagnostic.cpp
@@ -25,7 +25,7 @@
 using namespace clang;
 
 static const enum raw_ostream::Colors noteColor =
-  raw_ostream::BLACK;
+  raw_ostream::CYAN;
 static const enum raw_ostream::Colors remarkColor =
   raw_ostream::BLUE;
 static const enum raw_ostream::Colors fixitColor =

``````````

</details>


https://github.com/llvm/llvm-project/pull/66997