[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 20 14:12:11 PDT 2023
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Everything looks great now, let's commit!
Again, thank you Ziqing for simplifying and splitting up the patch. It looks like we're able to keep code complexity from exploding. That makes me feel very optimistic about the future of `-Wunsafe-buffer-usage`!
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1450
+ End = // `D->getEndLoc` should always return the starting location of the
+ // last token, so we should get the end of the token
+ Lexer::getLocForEndOfToken(D->getEndLoc(), 0, SM, LangOpts);
----------------
Formatting is a bit off (clang-format probably needed some human help here).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153059/new/
https://reviews.llvm.org/D153059
More information about the cfe-commits
mailing list