[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

[Erich Keane via cfe-commits]

Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>,
Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/66514/clang at github.com>


erichkeane wrote:

That doesn't look awful... what about blue/cyan/green?  Does that look not ugly?

Its a little tough as you say, the only colors that are 'meaningful' here are: [RED],[GREEN],[YELLOW],[BLUE],[MAGENTA],[CYAN]
(black and white excluded because black is 'background' typically, and white is the normal text color). 

I'd probably nix Red, just because it is used for 'error' and is rarely used for syntax anyway.  Magenta seems weird for syntax highlighting as well, so that leaves Green, Yellow, Blue, Cyan.

Blue for keywords/etc makes a lot of sense, that is a common color that is pretty universal.  Green is interesting, it is sorta 1/2 and 1/2 used for comments or literals it looks from some dark-mode image-googling.  I think a coin flip on Green works either way (though a SLIGHT personal preference for comments?).  So that leaves Yellow/Cyan for the other.  I have a hard time being able to choose.

BTW, appreciate your patience here on the colors, I'm hopeful someone with better ideas/opinions than mine (which is quite unhelpful at the moment obviously) will come along and just 'choose'.

https://github.com/llvm/llvm-project/pull/66514